From 2fe63be6c993bcd8d223a2f9f1a3309a52530905 Mon Sep 17 00:00:00 2001 From: lliyueling Date: Thu, 23 Apr 2026 14:57:36 +0800 Subject: [PATCH 1/2] =?UTF-8?q?refactor(http):=20=E4=BC=98=E5=8C=96=20repl?= =?UTF-8?q?aceUrlQuery=20=E6=96=B9=E6=B3=95=EF=BC=8C=E4=BD=BF=E7=94=A8=20H?= =?UTF-8?q?utool=20=E5=8E=9F=E7=94=9F=20API?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - 移除了对 Hutool `UrlQuery` 内部 `query` 字段的反射访问和强制类型转换。 - 直接使用 `UrlBuilder.getQuery().remove(key)` 链式调用，代码更简洁。 - 降低了代码与 Hutool 内部实现的耦合度，提高了代码的健壮性和可读性。 --- .../iocoder/yudao/framework/common/util/http/HttpUtils.java | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/yudao-framework/yudao-common/src/main/java/cn/iocoder/yudao/framework/common/util/http/HttpUtils.java b/yudao-framework/yudao-common/src/main/java/cn/iocoder/yudao/framework/common/util/http/HttpUtils.java index 9de037758..a31f4820c 100644 --- a/yudao-framework/yudao-common/src/main/java/cn/iocoder/yudao/framework/common/util/http/HttpUtils.java +++ b/yudao-framework/yudao-common/src/main/java/cn/iocoder/yudao/framework/common/util/http/HttpUtils.java @@ -1,9 +1,7 @@ package cn.iocoder.yudao.framework.common.util.http; import cn.hutool.core.codec.Base64; -import cn.hutool.core.map.TableMap; import cn.hutool.core.net.url.UrlBuilder; -import cn.hutool.core.util.ReflectUtil; import cn.hutool.core.util.StrUtil; import cn.hutool.http.HttpRequest; import cn.hutool.http.HttpResponse; @@ -66,9 +64,7 @@ public class HttpUtils { public static String replaceUrlQuery(String url, String key, String value) { UrlBuilder builder = UrlBuilder.of(url, Charset.defaultCharset()); // 先移除 - TableMap query = (TableMap) - ReflectUtil.getFieldValue(builder.getQuery(), "query"); - query.remove(key); + builder.getQuery().remove(key); // 后添加 builder.addQuery(key, value); return builder.build(); From adbcc60225a06c10b58f1545fb0a9a87020c0b18 Mon Sep 17 00:00:00 2001 From: lliyueling Date: Thu, 23 Apr 2026 15:40:37 +0800 Subject: [PATCH 2/2] =?UTF-8?q?test(common):=20=E8=A1=A5=E5=85=85=20HttpUt?= =?UTF-8?q?ils.replaceUrlQuery=20=E5=8D=95=E5=85=83=E6=B5=8B=E8=AF=95?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - 新增 HttpUtilsTest 测试类 - 覆盖参数替换、新增参数、空值处理等场景 - 确保优化后的 Hutool 实现与原反射实现行为一致 --- .../common/util/http/HttpUtilsTest.java | 50 +++++++++++++++++++ 1 file changed, 50 insertions(+) create mode 100644 yudao-framework/yudao-common/src/test/java/cn/iocoder/yudao/framework/common/util/http/HttpUtilsTest.java diff --git a/yudao-framework/yudao-common/src/test/java/cn/iocoder/yudao/framework/common/util/http/HttpUtilsTest.java b/yudao-framework/yudao-common/src/test/java/cn/iocoder/yudao/framework/common/util/http/HttpUtilsTest.java new file mode 100644 index 000000000..861598a56 --- /dev/null +++ b/yudao-framework/yudao-common/src/test/java/cn/iocoder/yudao/framework/common/util/http/HttpUtilsTest.java @@ -0,0 +1,50 @@ +package cn.iocoder.yudao.framework.common.util.http; + +import org.junit.jupiter.api.Test; +import static org.junit.jupiter.api.Assertions.assertEquals; + +public class HttpUtilsTest { + + @Test + public void testReplaceUrlQuery() { + // 定义测试用例：{原始URL, Key, Value, 期望结果} + String[][] testCases = { + // 场景1: 替换已存在的参数 (注意参数顺序可能会变，因为 UrlQuery 内部是 List) + {"https://example.com/path?a=1&b=2", "a", "3", "https://example.com/path?b=2&a=3"}, + // 场景2: 添加不存在的参数 + {"https://example.com/path?a=1", "b", "2", "https://example.com/path?a=1&b=2"}, + // 场景3: URL 本身没有查询参数 + {"https://example.com/path", "a", "1", "https://example.com/path?a=1"}, + // 场景4: 值为空 (根据原逻辑，空值通常会被移除或不添加，这里假设是移除) + // 注意：你需要根据 HttpUtils 实际对 null/empty 的处理来调整 expected + {"https://example.com/path?a=1", "a", "", "https://example.com/path?a="}, + }; + + System.out.println("开始运行 HttpUtils.replaceUrlQuery 测试..."); + + for (int i = 0; i < testCases.length; i++) { + String[] currentCase = testCases[i]; // 必须先取出当前这一行的数组 + + String url = currentCase[0]; + String key = currentCase[1]; + String value = currentCase[2]; + String expected = currentCase[3]; + + // 调用你优化后的方法 + String actual = HttpUtils.replaceUrlQuery(url, key, value); + + // 核心验证：断言实际结果必须等于期望结果 + // 如果不相等，测试会直接报错，并打印出是哪一行错了 + try { + assertEquals(expected, actual, "测试用例 " + (i + 1) + " 失败: " + url); + System.out.println("✅ 用例 " + (i + 1) + " 通过: " + actual); + } catch (AssertionError e) { + System.err.println("❌ 用例 " + (i + 1) + " 失败!"); + System.err.println(" 输入: " + url + " | " + key + "=" + value); + System.err.println(" 期望: " + expected); + System.err.println(" 实际: " + actual); + throw e; // 抛出错误，让测试标记为失败 + } + } + } +} \ No newline at end of file