From ec87c1b61d8cb77e62142cf2c7607a8732433163 Mon Sep 17 00:00:00 2001
From: YunaiV <zhijiantianya@gmail.com>
Date: Sun, 7 Jan 2024 21:20:00 +0800
Subject: [PATCH] =?UTF-8?q?=F0=9F=93=96=20CRM=EF=BC=9Acode=20review=20crm?=
 =?UTF-8?q?=20=E5=AE=A2=E6=88=B7=E5=88=97=E8=A1=A8?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 src/api/crm/customer/index.ts                 |  3 +-
 .../OperateLogV2/src/OperateLogV2.vue         |  1 +
 src/views/crm/customer/detail/index.vue       | 30 ++++++++++++-------
 src/views/crm/customer/index.vue              | 10 +++++--
 4 files changed, 31 insertions(+), 13 deletions(-)

diff --git a/src/api/crm/customer/index.ts b/src/api/crm/customer/index.ts
index cfc3613f..5ec8a3ea 100644
--- a/src/api/crm/customer/index.ts
+++ b/src/api/crm/customer/index.ts
@@ -73,13 +73,14 @@ export const getOperateLogPage = async (id: number) => {
   return await request.get({ url: '/crm/customer/operate-log-page?id=' + id })
 }
 
-//======================= 业务操作 =======================
+// ======================= 业务操作 =======================
 
 // 锁定/解锁客户
 export const lockCustomer = async (id: number, lockStatus: boolean) => {
   return await request.put({ url: `/crm/customer/lock`, data: { id, lockStatus } })
 }
 
+// TODO @puhui999：方法名，改成和后端一致哈
 // 领取公海客户
 export const receive = async (ids: any[]) => {
   return await request.put({ url: '/crm/customer/receive', params: { ids: ids.join(',') } })
diff --git a/src/components/OperateLogV2/src/OperateLogV2.vue b/src/components/OperateLogV2/src/OperateLogV2.vue
index e3b00e2e..ae8aad40 100644
--- a/src/components/OperateLogV2/src/OperateLogV2.vue
+++ b/src/components/OperateLogV2/src/OperateLogV2.vue
@@ -1,4 +1,5 @@
 <template>
+  <!-- TODO @puhui999：左边不用有空隙哈 -->
   <div class="p-20px">
     <el-timeline>
       <el-timeline-item
diff --git a/src/views/crm/customer/detail/index.vue b/src/views/crm/customer/detail/index.vue
index 6ea4bf72..15472124 100644
--- a/src/views/crm/customer/detail/index.vue
+++ b/src/views/crm/customer/detail/index.vue
@@ -1,5 +1,6 @@
 <template>
   <CustomerDetailsHeader :customer="customer" :loading="loading">
+    <!-- @puhui999：返回是不是可以去掉哈，貌似用途可能不大 -->
     <el-button @click="close">返回</el-button>
     <!-- TODO puhui999: 按钮数据权限收尾统一完善，需要按权限分级和客户状态来动态显示匹配的按钮 -->
     <el-button v-hasPermi="['crm:customer:update']" type="primary" @click="openForm">
@@ -12,7 +13,7 @@
     <el-button v-if="customer.lockStatus" @click="handleUnlock">解锁</el-button>
     <el-button v-if="!customer.lockStatus" @click="handleLock">锁定</el-button>
     <el-button v-if="!customer.ownerUserId" type="primary" @click="receive">领取客户</el-button>
-    <el-button v-if="customer.ownerUserId" type="primary" @click="putPool">客户放入公海</el-button>
+    <el-button v-if="customer.ownerUserId" @click="putPool">客户放入公海</el-button>
   </CustomerDetailsHeader>
   <el-col>
     <el-tabs>
@@ -67,6 +68,7 @@ const loading = ref(true) // 加载中
 const message = useMessage() // 消息弹窗
 const { delView } = useTagsViewStore() // 视图操作
 const { currentRoute, push } = useRouter() // 路由
+
 /** 获取详情 */
 const customer = ref<CustomerApi.CustomerVO>({} as CustomerApi.CustomerVO) // 客户详情
 const getCustomer = async () => {
@@ -78,45 +80,51 @@ const getCustomer = async () => {
     loading.value = false
   }
 }
+
+/** 编辑客户 */
 const formRef = ref<InstanceType<typeof CustomerForm>>() // 客户表单 Ref
-// 编辑客户
 const openForm = () => {
   formRef.value?.open('update', customerId.value)
 }
-// 客户转移
+
+/** 客户转移 */
 const transfer = () => {}
-// 锁定客户
+
+/** 锁定客户 */
 const handleLock = async () => {
   await message.confirm(`确定锁定客户【${customer.value.name}】 吗？`)
   await CustomerApi.lockCustomer(unref(customerId.value), true)
   message.success(`锁定客户【${customer.value.name}】成功`)
   await getCustomer()
 }
-// 解锁客户
+
+/** 解锁客户 */
 const handleUnlock = async () => {
   await message.confirm(`确定解锁客户【${customer.value.name}】 吗？`)
   await CustomerApi.lockCustomer(unref(customerId.value), false)
   message.success(`解锁客户【${customer.value.name}】成功`)
   await getCustomer()
 }
-// 领取客户
+
+// TODO @puhui999：下面两个方法的命名，也用 handleXXX 风格哈
+/** 领取客户 */
 const receive = async () => {
   await message.confirm(`确定领取客户【${customer.value.name}】 吗？`)
   await CustomerApi.receive([unref(customerId.value)])
   message.success(`领取客户【${customer.value.name}】成功`)
   await getCustomer()
 }
-// 客户放入公海
+
+/** 客户放入公海 */
 const putPool = async () => {
   await message.confirm(`确定将客户【${customer.value.name}】放入公海吗？`)
   await CustomerApi.putPool(unref(customerId.value))
   message.success(`客户【${customer.value.name}】放入公海成功`)
   close()
 }
+
+/** 获取操作日志 */
 const logList = ref<OperateLogV2VO[]>([]) // 操作日志列表
-/**
- * 获取操作日志
- */
 const getOperateLog = async () => {
   if (!customerId.value) {
     return
@@ -124,11 +132,13 @@ const getOperateLog = async () => {
   const data = await CustomerApi.getOperateLogPage(customerId.value)
   logList.value = data.list
 }
+
 const close = () => {
   delView(unref(currentRoute))
   // TODO 先返回到客户列表
   push({ name: 'CrmCustomer' })
 }
+
 /** 初始化 */
 const { params } = useRoute()
 onMounted(() => {
diff --git a/src/views/crm/customer/index.vue b/src/views/crm/customer/index.vue
index 3d10e72e..3ca7b022 100644
--- a/src/views/crm/customer/index.vue
+++ b/src/views/crm/customer/index.vue
@@ -100,9 +100,10 @@
 
   <!-- 列表 -->
   <ContentWrap>
+    <!-- TODO @puhui999：是不是就 3 重呀，我负责的，我参与的，我下属的 -->
     <el-tabs v-model="activeName" @tab-click="handleClick">
       <el-tab-pane label="客户列表" name="1" />
-      <el-tab-pane label="我负责人的" name="2" />
+      <el-tab-pane label="我负责的" name="2" />
       <el-tab-pane label="我关注的" name="3" />
       <el-tab-pane label="我参与的" name="4" />
       <el-tab-pane label="下属负责的" name="5" />
@@ -270,6 +271,7 @@ const handleClick = (tab: TabsPaneContext) => {
         queryParams.value.sceneType = CrmSceneTypeEnum.FOLLOW
       })
       break
+    // TODO @puhui999：这个貌似报错？
     case '4':
       resetQuery(() => {
         queryParams.value.sceneType = CrmSceneTypeEnum.INVOLVED
@@ -280,6 +282,7 @@ const handleClick = (tab: TabsPaneContext) => {
         queryParams.value.sceneType = CrmSceneTypeEnum.SUBORDINATE
       })
       break
+    // TODO @puhui999：公海单独一个菜单哈。
     case '6':
       resetQuery(() => {
         queryParams.value.pool = true
@@ -287,6 +290,7 @@ const handleClick = (tab: TabsPaneContext) => {
       break
   }
 }
+
 /** 查询列表 */
 const getList = async () => {
   loading.value = true
@@ -362,13 +366,15 @@ const handleExport = async () => {
     exportLoading.value = false
   }
 }
-// 监听路由变化更新列表
+
+/** 监听路由变化更新列表 */
 watch(
   () => currentRoute.value,
   () => {
     getList()
   }
 )
+
 /** 初始化 **/
 onMounted(() => {
   getList()