From 06e2019adf164b2562911ced48287e72505d65d8 Mon Sep 17 00:00:00 2001
From: YunaiV <zhijiantianya@gmail.com>
Date: Sat, 17 Feb 2024 18:02:40 +0800
Subject: [PATCH] =?UTF-8?q?=F0=9F=93=96=20CRM=EF=BC=9Acode=20review=20?=
 =?UTF-8?q?=E5=BE=85=E5=8A=9E=E9=A1=B9=E7=9B=AE=E7=9A=84=E5=AE=9E=E7=8E=B0?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 src/router/modules/remaining.ts                | 11 -----------
 src/views/crm/backlog/index.vue                |  7 ++-----
 src/views/crm/backlog/tables/CheckContract.vue |  3 +--
 src/views/crm/backlog/tables/TodayCustomer.vue |  8 +++++---
 src/views/crm/customer/index.vue               |  6 +++---
 5 files changed, 11 insertions(+), 24 deletions(-)

diff --git a/src/router/modules/remaining.ts b/src/router/modules/remaining.ts
index edda3820..4eec8cd4 100644
--- a/src/router/modules/remaining.ts
+++ b/src/router/modules/remaining.ts
@@ -539,17 +539,6 @@ const remainingRouter: AppRouteRecordRaw[] = [
           activeMenu: '/crm/product'
         },
         component: () => import('@/views/crm/product/detail/index.vue')
-      },
-      {
-        path: 'backlog',
-        name: 'CrmBacklog',
-        meta: {
-          title: '待办事项',
-          noCache: true,
-          hidden: true
-        },
-        // TODO @db52：后面搞，搞成菜单
-        component: () => import('@/views/crm/backlog/index.vue')
       }
     ]
   }
diff --git a/src/views/crm/backlog/index.vue b/src/views/crm/backlog/index.vue
index 5fb53960..0d42c960 100644
--- a/src/views/crm/backlog/index.vue
+++ b/src/views/crm/backlog/index.vue
@@ -1,4 +1,3 @@
-<!-- TODO @dhb52: 存在很多重复的 table 定义，如Customer: TodayCustomer,FollowCustomer,PutInPoolRemind -->
 <template>
   <el-row :gutter="20">
     <el-col :span="4" class="min-w-[200px]">
@@ -90,10 +89,8 @@ const leftSides = ref([
   }
 ])
 
-/**
- * 侧边点击
- */
-const sideClick = (item) => {
+/** 侧边点击 */
+const sideClick = (item: any) => {
   leftType.value = item.infoType
 }
 // TODO @dhb52: 侧边栏样式，在黑暗模式下，颜色会不对。是不是可以读取主题色哈；
diff --git a/src/views/crm/backlog/tables/CheckContract.vue b/src/views/crm/backlog/tables/CheckContract.vue
index 87786f5b..ad4782e0 100644
--- a/src/views/crm/backlog/tables/CheckContract.vue
+++ b/src/views/crm/backlog/tables/CheckContract.vue
@@ -126,8 +126,6 @@ import { fenToYuanFormat } from '@/utils/formatter'
 import { DICT_TYPE } from '@/utils/dict'
 import { AUDIT_STATUS } from './common'
 
-const { push } = useRouter() // 路由
-
 const loading = ref(true) // 列表的加载中
 const total = ref(0) // 列表的总页数
 const list = ref([]) // 列表的数据
@@ -157,6 +155,7 @@ const handleQuery = () => {
 }
 
 /** 打开客户详情 */
+const { push } = useRouter() // 路由
 const openCustomerDetail = (id: number) => {
   push({ name: 'CrmCustomerDetail', params: { id } })
 }
diff --git a/src/views/crm/backlog/tables/TodayCustomer.vue b/src/views/crm/backlog/tables/TodayCustomer.vue
index f98107af..4c6ce467 100644
--- a/src/views/crm/backlog/tables/TodayCustomer.vue
+++ b/src/views/crm/backlog/tables/TodayCustomer.vue
@@ -43,8 +43,8 @@
   </ContentWrap>
   <ContentWrap>
     <el-table v-loading="loading" :data="list" :show-overflow-tooltip="true" :stripe="true">
-      <el-table-column align="center" label="编号" prop="id" />
-      <el-table-column align="center" label="客户名称" prop="name" width="160">
+      <el-table-column align="center" label="编号" fixed="left" prop="id" />
+      <el-table-column align="center" label="客户名称" fixed="left" prop="name" width="160">
         <template #default="scope">
           <el-link :underline="false" type="primary" @click="openDetail(scope.row.id)">
             {{ scope.row.name }}
@@ -82,7 +82,7 @@
           <dict-tag :type="DICT_TYPE.INFRA_BOOLEAN_STRING" :value="scope.row.dealStatus" />
         </template>
       </el-table-column>
-      <el-table-column align="center" label="距进入公海天数" prop="poolDay" width="100px" />
+      <el-table-column align="center" label="距进入公海天数" prop="poolDay" width="130" />
       <el-table-column
         :formatter="dateFormatter"
         align="center"
@@ -124,6 +124,8 @@ import { DICT_TYPE } from '@/utils/dict'
 import { dateFormatter } from '@/utils/formatTime'
 import { CONTACT_STATUS, SCENE_TYPES } from './common'
 
+// defineOptions({ name: 'TodayCustomer' }) TODO @dhb52：1）定义改成这种；2）命名要不要改成 CustomerTodayTable，就是 模块+形容词+表格（更容易识别），然后把 tables 目录改成 components 目录
+
 const { push } = useRouter()
 
 const loading = ref(true) // 列表的加载中
diff --git a/src/views/crm/customer/index.vue b/src/views/crm/customer/index.vue
index 10911c37..a459664c 100644
--- a/src/views/crm/customer/index.vue
+++ b/src/views/crm/customer/index.vue
@@ -110,8 +110,8 @@
       <el-tab-pane label="下属负责的" name="3" />
     </el-tabs>
     <el-table v-loading="loading" :data="list" :show-overflow-tooltip="true" :stripe="true">
-      <el-table-column align="center" label="编号" prop="id" />
-      <el-table-column align="center" label="客户名称" prop="name" width="160">
+      <el-table-column align="center" label="编号" fixed="left" prop="id" />
+      <el-table-column align="center" label="客户名称" fixed="left" prop="name" width="160">
         <template #default="scope">
           <el-link :underline="false" type="primary" @click="openDetail(scope.row.id)">
             {{ scope.row.name }}
@@ -149,7 +149,7 @@
           <dict-tag :type="DICT_TYPE.INFRA_BOOLEAN_STRING" :value="scope.row.dealStatus" />
         </template>
       </el-table-column>
-      <el-table-column align="center" label="距离进入公海" prop="poolDay">
+      <el-table-column align="center" label="距离进入公海" prop="poolDay" width="120">
         <template #default="scope"> {{ scope.row.poolDay }} 天</template>
       </el-table-column>
       <el-table-column